Re: Re: Reg Expression on file name

so it's more effective to say:

next unless
        substr($file,0,6) eq 'AB DAT'
    and substr($file,-4)  eq '.doc'
;
[download]

A. That's not more effective. It's just as effective. It may be ever so slightly more efficient but the micro-optimization probably isn't really all that important.

B. It's verbose and harder to read at a glance than a simple regular expression is. This is probably more important than whatever small optimization you might get by using substr.

If the filename were in $_ I'd suggest next unless /^AB DAT/ and /\.doc/; which would be a good compromise.

I just noticed your first suggestion:

next unless $file =~ m/^ AB \s DAT .* \.doc $/x;
[download]

I think this case in particular would really be a good time to use a literal space instead of \s and avoid /x. In general, I think /x makes short regular expressions harder to read. Do you often use /x on short expressions and if so, what's your reasoning?

-sauoq
"My two cents aren't worth a dime.";

Comment on Re: Re: Reg Expression on file name Select or Download Code

Replies are listed 'Best First'.
Re: Re: Re: Reg Expression on file name by fruiture (Curate) on Jan 06, 2003 at 21:03 UTC
True, it's more readable to have an expression and the kind-of-best way is the one with two expressions. To make this quite efficient and readable, a prepost($name,$prefix,$postfix) function using substr inside would be the solution if this problem occurs more than once. This is hypothetical, it's perhaps only 30 lines of code where neither speed nor readability matter :) About /x: I'm starting to use it nearly everywhere, i don't think it makes anything harder to read. Perl 6 regular expressions (which are then somehow comparable to Parse::RecDescent now) are /x'ed by default, getting used to this is probably helpful. Imho it makes any expression more readable, at least after you're used to it. You see this differently, because you're probably used to compact expressions because they are common in Perl 5. Try forcing yourself to make everything very optical via /x and you'll change your mind in a week. -- http://fruiture.de	[reply]

Replies are listed 'Best First'.

Re: Re: Re: Reg Expression on file name
by fruiture (Curate) on Jan 06, 2003 at 21:03 UTC

True, it's more readable to have an expression and the kind-of-best way is the one with two expressions. To make this quite efficient and readable, a prepost($name,$prefix,$postfix) function using substr inside would be the solution if this problem occurs more than once. This is hypothetical, it's perhaps only 30 lines of code where neither speed nor readability matter :)

About /x: I'm starting to use it nearly everywhere, i don't think it makes anything harder to read. Perl 6 regular expressions (which are then somehow comparable to Parse::RecDescent now) are /x'ed by default, getting used to this is probably helpful. Imho it makes any expression more readable, at least after you're used to it. You see this differently, because you're probably used to compact expressions because they are common in Perl 5. Try forcing yourself to make everything very optical via /x and you'll change your mind in a week.

fruiture

[reply]