in reply to Re: Re: Converting MAC Address
in thread Converting MAC Address

Try 

$foo = "0:0A:0C:B:B8:F";
$foo =~ s/([0-9A-F]+)(?::|$)/length($1) < 2?"0$1":$1/ge; 
print $foo

000A0C0BB80F

[download]

With your version [0-9A-F]+ can just as easily match one hex char as two as the :? part is optional (so that you will match at the end of line. Therefore, it matches the ...:B8:... in two chunks instead of one.

The version above makes the : or end-of-string mandatory (?::|$) and forces the B8 part to be matched as a single piece rather than two.

Not necessarially the best way to do it, but it corrects the problem you've identified.

You can also simplify the right-hand side of the s/// somewhat like this: 

$foo =~ s/([0-9A-F]+)(?::|$)/substr "0$1", -2/ge;

[download]

Examine what is said, not who speaks.

The 7th Rule of perl club is -- pearl clubs are easily damaged. Use a diamond club instead.

Replies are listed 'Best First'.
Re: Re: Re: Re: Converting MAC Address
by Enlil (Parson) on Jan 11, 2003 at 01:59 UTC
    ++BrowserUK for the simplification of the right hand side, but the only problem with the version I first posted was just the placement of the + outside the capturing parenthesis.

    The :? was only there to remove the : not to delimit (correct word i hope), where the regular expression would stop matching but to remove it if it existed after a string of characters in [0-9A-F]. Thus the (?::|$) is unnecassary, as it will stop when it hits something outside [0-9A-F] anyway, whether it is a colon or the end of the line.

    After further thought the reason:

    $foo =~ s/([0-9A-F])+:?/length($1) < 2?"0$1":$1/ge;

    [download]
    does not work how it was intended is because ([0-9A-F])+ in the B8 part (the other parts worked because of a fluke of circumstance, but had they all been B8 the error would have been glaringly apparent), but I digress, the reason it did not work for the B8:, is that it first captures the B but the + makes it want more so it continues to with the 8 but since we don't have a + on the inside(ie. ([A-F0-9]+)) the B is tossed, well technically is part of the successful match, but the due to the placement of the + the $1 is now 8. Now, it tries for something else in this character class, but since there is nothing it continues to the next part of the expression, and since the : is the next thing it needs to match (if it is there, hence the ? after the :), it matches successfully, and life goes on, and if no one else learned anything from my spiel, I did, and that counts for something

    -enlil

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom