Re^2: getting files from Dir

As an aside to this, if you are using ||, make sure you've got the parentheses around the arguments passed to opendir. Otherwise you'll be testing for the value of $somedir and dying if $somedir is an empty or undefined scalar. Better yet, just use 'or', so that your test on the success of opening the directory will do what you are expected, whether or not the parentheses are present:

opendir DIR, $somedir or die "Could not open '$somedir': $!";
[download]

Also, if your script is going to be extremely long, you might want to exclude the newline (\n) at the end of your die statement, to make debugging easier (ie: knowing which line in your program died on you. In this case however, it seems to be a short script, so you'll probably know where the problem is. :)

"User error. Replace user and press any key to continue."

Comment on Re^2: getting files from Dir Download Code

Replies are listed 'Best First'.
Re: Re^2: getting files from Dir by vek (Prior) on Jan 25, 2003 at 15:49 UTC
You make a couple of good points Coruscate and are probably worth pointing out to avoid confusion. I made that observation myself in this thread. For the record though, I generally use parentheses around functions (just my coding style) and therefore use `\|\|` and `&&` when testing return values: `open($someFile) \|\| die "Couldn't open $someFile - $!\n"; opendir(DIR, $someDir) \|\| die "Couldn't open $someDir - $!\n"; system($shellCommand) && die "Couldn't run $shellCommand - $!\n";` [download] -- vek --	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Re^2: getting files from Dir
by vek (Prior) on Jan 25, 2003 at 15:49 UTC

Coruscate

made

this

||

&&

open($someFile) || die "Couldn't open $someFile - $!\n";
opendir(DIR, $someDir) || die "Couldn't open $someDir - $!\n";
system($shellCommand) && die "Couldn't run $shellCommand - $!\n";
[download]

vek

[reply]
[d/l]
[select]