Re: Re: Adding dynamic parameters to a URL

Well, you asked:

ALWAYS check the return value from open(); you're inconsistent in your error checking
You use local when you mean my in the error routine.
You slurp the file rather than reading line by line (granted that if you get to point that that would be an issue you'd really want a real database anyhow . . .)
You don't do any sort of file locking to guarantee that you don't clobber the database if multiple people hit simultaneously (or close enough to simultaneously)
eq is for strings, == is for numeric comparisons.

I'll stop there.

Comment on Re: Re: Adding dynamic parameters to a URL Select or Download Code

Replies are listed 'Best First'.
Re: Re: Re: Adding dynamic parameters to a URL by huskey (Beadle) on Feb 03, 2003 at 17:46 UTC
thank you for the help. just one question. the only reason i didn't use file locking was that it was my understanding that not all platforms use file locking in the same way, and as the original question did not say what platform they were using so i left it out.	[reply]
Re: Re: Re: Re: Adding dynamic parameters to a URL by Fletch (Bishop) on Feb 03, 2003 at 17:59 UTC
See `perldoc perlopentut`, specifically the section entitled File Locking. Perl will at least try and emulate something resembling `flock()` everywhere.	[reply] [d/l] [select]