Re: Re: Finding the intersect of two ranges

I like your's a lot, however I don't think you need the "+1" at the end. Also, what happens if the intersect is zero? I think your's would return negative. eg. overlap(1,2,4,5)

-caedes

Comment on Re: Re: Finding the intersect of two ranges

Replies are listed 'Best First'.
Re: Re: Re: Finding the intersect of two ranges by BrowserUk (Patriarch) on Feb 04, 2003 at 09:40 UTC
Your right. Unfortunately, little diagrams on paper don't always make for good testcases. The +1 was a um...fencepost error! `1 2 3 4 5 2 3 4 5 6 1 2 3 4 <<< Range = 4 NOT!` [download] Since when does a coder count from 1 not zero! The idea was that if the range is negative, it has to be wrong so, no overlap. Which of course leads onto the second error. My original tests were these. Read more... (3 kB) I think I tried all the variations this time, but as always, better minds and different eyes may see it differently. Examine what is said, not who speaks. The 7th Rule of perl club is -- pearl clubs are easily damaged. Use a diamond club instead.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Re: Re: Finding the intersect of two ranges
by BrowserUk (Patriarch) on Feb 04, 2003 at 09:40 UTC

Your right. Unfortunately, little diagrams on paper don't always make for good testcases. The +1 was a um...fencepost error!

1 2 3 4 5
  2 3 4 5 6
  1 2 3 4 <<< Range = 4  NOT!
[download]

Since when does a coder count from 1 not zero!

The idea was that if the range is negative, it has to be wrong so, no overlap. Which of course leads onto the second error.

My original tests were these.