in reply to Re: Re: loop control
in thread loop control

OK, that's a lot clearer. The basic thing you're doing wrong is using angle brackets to go through a list, which is not necessary. The angle brackets are generally associated with doing I/O.

But you're also doing a lot of unnecessary work, like the way you're counting up the number of items you're pushing into your list. Perl has constructs for doing that kind of stuff much more easily; you can even do it in one line, like this: push @list, (split ' ')[3] foreach <$syscmd>;In case that's too compact, here's the equivalent broken up a little more:

while (<$syscmd>) { my @temp = split ' '; push @list, $temp[3]; }
Of course, this also takes up more space, for the temporary array.

Your main loop searches an array for a matching element. That's a common enough construct that perl has a special construct for it, the grep function. Here's how you'd use it in this context:

foreach my $val (sort keys %prolist) { unless (grep($prolist{$val} eq $_)) { print "NF: $prolist{$val}\n"; } }
There are ways to tighten up that loop, but this lets you see what's going on. Your original code can be fixed by just taking out the angle brackets in the while, but you may as well pick up some perl nifty tricks while you're at it.

(BTW, I haven't tested any of this code.)

Replies are listed 'Best First'.
Re: Re (3): loop control
by steves (Curate) on Feb 04, 2003 at 17:14 UTC

    While the use of the angle brackets here is strange and unnecessary, I don't see how it breaks the original code. I tried it, and it works fine with Perl 5.6.1. I thought that maybe the while on <@list> would maybe only work once; i.e.; the first end-of-list would behave like and EOF and have to be reset somehow. But that's not the case in my tests.

    my @x = (qw/a b c abc def ghi z/); while (<@x>) { print "<$_>\n"; } print "\n\n"; while (<@x>) { print "<$_>\n"; }

    <a> <b> <c> <abc> <def> <ghi> <z> <a> <b> <c> <abc> <def> <ghi> <z>

      That worked because you had no files in the current directory named a, b, c, abc, ..., or any of the strings in @x. The angle brackets are globbing in this case, as John M. Dlugosz pointed out above. Check out perlio, then try adding * to @x and running your code again.