in reply to Re: First Unix Admin Script - Request for Constructive Critisism
in thread First Unix Admin Script - Request for Constructive Critisism
One minor nit pick:
You don't test for success when you open MPCFG, and you open it without closing it. You could run out of open file handles
Filehandles are global (another good reason for preferring IO::File as you suggest) so if open is called with a FILEHANDLE argument that refers to an already open file, the FILEHANDLE is closed first. The original script might not be good style, but it doesn't leak filehandles.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re: Re: First Unix Admin Script - Request for Constructive Critisism
by D.Millin (Beadle) on Feb 08, 2003 at 21:13 UTC | |
by grantm (Parson) on Feb 09, 2003 at 02:55 UTC |