Re: Re: First Unix Admin Script - Request for Constructive Critisism

Hi tachyon,

I have been given some thought to your suggestion to have a check_call sub. I guess one approach would be to adapt check_call each type, or class of command. Reporting would still need to be done in plain english for the operators, so instead of passing @stuff, I could always pass in appropriate parameters. BTW, is there any way of redirecting STDOUT,STDERR when system is called in a list context?

Darren

Comment on Re: Re: First Unix Admin Script - Request for Constructive Critisism

Replies are listed 'Best First'.
Re^3: First Unix Admin Script - Request for Constructive Critisism by tall_man (Parson) on Feb 09, 2003 at 01:08 UTC
You ask about redirecting STDOUT and STDERR for system calls given as lists. A good way to do this is with the module IPC::Run. `use IPC::Run qw( run ) ; run \@cmd, \$in, \$out, \$err;` [download] One idea you might be able to use for parameterizing your error messages for various commands would be to pass in a hash reference containing explanatory messages indexed by return codes. Also see perlvar for how you can use the variable `$!` to obtain error message strings after a failed system call. Finally, the reason spelled-out file handles are considered "bad style" compared to IO::File is that they create global names, which might conflict with other modules. IO::File uses unique private symbols instead.	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re^3: First Unix Admin Script - Request for Constructive Critisism
by tall_man (Parson) on Feb 09, 2003 at 01:08 UTC

IPC::Run

use IPC::Run qw( run ) ;
run \@cmd, \$in, \$out, \$err;
[download]

One idea you might be able to use for parameterizing your error messages for various commands would be to pass in a hash reference containing explanatory messages indexed by return codes. Also see perlvar for how you can use the variable $! to obtain error message strings after a failed system call.

Finally, the reason spelled-out file handles are considered "bad style" compared to IO::File is that they create global names, which might conflict with other modules. IO::File uses unique private symbols instead.

[reply]
[d/l]
[select]