Re: Re**3: Eek! goto?

I've tried to make this work. I added the implied while loop and put brackets around the 'a' etc. to make it generate lists not strings, but I still can get it to produce the same results as the original. Can you see what I missed?

sub belg4mit {
    my %H;
    my ($len, @k) = @_;
    my ($a,$b,$c) = (0)x3;
    while($len--) {
         $H{(('a')x4,('b')x4,('c')x3)[$len]}
            += $k[$len -1] << (8* ( ($len > 8 ? $len : $len - 1 )%4 ) 
+);
    }
    return ($H{a}||0)+($H{b}||0)+($H{c}||0);
}
[download]

Examine what is said, not who speaks.

The 7th Rule of perl club is -- pearl clubs are easily damaged. Use a diamond club instead.

Comment on Re: Re**3: Eek! goto? Download Code

Replies are listed 'Best First'.
Re**5: Eek! goto? by belg4mit (Prior) on Feb 12, 2003 at 18:12 UTC
`while($len){ $H{(('a')x4,('b')x4,('c')x3)[--$len]} += $k[$len] << (8* ( ($len > 7 ? $len +1 : $len)%4 ) ); }` [download] This seems to match the output of pfaut's code. If benchmarking you could eek out some more throughput by storing the hash key indexes in an array (as opposed to forcing three `x` per iteration of the loop. `-- I'm not belgian but I play one on TV.`	[reply] [d/l]
Re: Re**5: Eek! goto? by pfaut (Priest) on Feb 12, 2003 at 18:27 UTC
Might be a bit faster if you throw out the hash and use an array. BTW, I think one of BrowserUK's later posts added back the originally missing low byte of $c so the check for $len > 7 can go, too. `while ($len--) { $H[int($len/4)] += $k[$len] << (8 * ($len % 4)); }` [download] `--- print map { my ($m)=1<<hex($_)&11?' ':''; $m.=substr('AHJPacehklnorstu',hex($_),1) } split //,'2fde0abe76c36c914586c';` [download]	[reply] [d/l] [select]