its not working though, and when i do this

my @temp = keys %labels;
my $temp2;
foreach(@temp) {
$temp2.="'$_'";
$temp2.=",";
}
chop $temp2;

print $q->popup_menu(-name=>'menu_name', -values=>$temp2, -default => $q->param('product'), -labels=>%labels);

It just prints $temp2 as one value.