in reply to Code review request for my first module - WWW::PostiniAdmin

afresh1,
I do not know anything about scraping web pages and I know even less about Postini, but there is something that bothers me about your code: 
if ($line =~/^&nbsp; &nbsp; &nbsp; &nbsp; <a href/) {

and elsewhere

elsif ($line =~ /<font color=/) {

[download]
This implies to me you are depending on the web site never to change their format. That's a pretty hefty risk. You would probably be better off using one of the HTML parsers on CPAN. I can't suggest one, as I indicated I know nothing when it comes to web page scraping, but this search should get you started.

Cheers - L~R

Replies are listed 'Best First'.
Re: Re: My first module. I can't find any problems with it!
by afresh1 (Hermit) on May 03, 2003 at 02:08 UTC
    I did look at dong that, unfortunately there isn't really any good structure to the page beyond what I am matching. The only differences that I can use are the number of &nbsp; there are the links are the same. It is a generated page, and they do notify me before they make changes to their code, so it is a bit of a problem, but I wasn't able to see how parsing the HTML made it any better.

    I am asking for a way to get a comma delimited version, but until then it looks a lot like this:

    Read more... (3 kB)
    -- andrew
[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom