in reply to (OT) The Honest Cherry Bomb

Some are just blunt and say "the code you wrote is stupid!" Others are even worse and say "you were stupid!" What does that gain us?

Bugfixes? If the code is stupid, and I say "Oh, you brilliant mind, what a wonderful code you've written", there's little chance the code will ever be fixed.

Sorry, I fail to see what's wrong with a bit of honesty. If I say code is wrong when it is wrong, and I praise code when it's good, it's easy to know when I make a compliment, and when I think the code can be improved. From someone who's always nicey-nicey, you'd never know.

Yeah, I know, your article has been directed to people like me. Some (many?) people find me blunt and "mean". I don't really care - anyone is free to ignore me. Granted, many forums are better suited to ignore someone (most Usenet and many email readers know killfiles) than perlmonks, but still. Although I rather be judged by my techical skills.

As for "don't do to others ...", I'm not doing to others that I wouldn't do to myself. If I write stupid code, please say so. Cut the nicey-nicey crap, go straight to the heart of the matter, point out what's wrong, and preferably, tell me what's better. Life is short - be to the point. And don't forget: this is a technical forum, it's not kindergarten.

If you can't stand the heat - stay out of the kitchen.

Abigail

Replies are listed 'Best First'.
Re: Re: (OT) The Honest Cherry Bomb
by Ovid (Cardinal) on May 28, 2003 at 22:11 UTC

    Abigail-II wrote:

    Bugfixes? If the code is stupid, and I say "Oh, you brilliant mind, what a wonderful code you've written", there's little chance the code will ever be fixed.

    Horns of a false dilemma: it's not the case that the choices are either being blunt or lying. There is nothing wrong with honesty, but if my intent is really to communicate with someone, then that intent is not served by potentially raising barriers to communication by putting them on the defensive.

    Consider "that code is awful and you shouldn't be doing it that way." versus "here's a better way to do this." If someone really wants to learn, they will learn either way. If someone is likely to get defensive, the first way will inhibit learning. Thus, if I really want to help someone, I don't start out by potentially making them mad.

    Cheers,
    Ovid

    New address of my CGI Course.
    Silence is Evil (feel free to copy and distribute widely - note copyright text)

      Consider "that code is awful and you shouldn't be doing it that way." versus "here's a better way to do this."

      Now you are assuming that that is either or. Many of my posts that are considered blunt (of course, tons of people consider anything I write to be blunt anyway) will also either show a better way, or have a pointer to it.

      Thus, if I really want to help someone, I don't start out by potentially making them mad.

      You do it your way, I do it my way. My advice on this and other forums is free, and people are free to ignore it. I'm willing to help people (but I'm not willing to spoonfeed them); I don't charge; I don't expect anything in return. But I will do it my way.

      Abigail

Re (2): (OT) The Honest Cherry Bomb
by VSarkiss (Monsignor) on May 29, 2003 at 02:32 UTC

    I disagree with the basic premise that your note seems to be implying: it's a technical forum, so it's OK to treat people disrespectfully. That logic is used by bullies in many different contexts: It's music class, so it's OK to yell at the students. Or, "It's football, dammit. It's supposed to hurt." No context makes shoddy treatment of people OK.

    As to "I'm not doing to others....", the tone of your writeup contradicts the notion that you take criticism well. "If I write stupid code, please say so", but we should not say anything about using an obnoxious tone? According to your note, it would be OK for me to put you down and insult you because I disagree with what you wrote. It would be easy, but it would still be wrong.

    It's your choice how to treat people, but please don't try to justify it by saying, "It's Perl, being thoughtful of others doesn't enter the equation." When human beings interact, mutual respect is always important, regardless of the topic being discussed.

Re: Re: (OT) The Honest Cherry Bomb
by Nkuvu (Priest) on May 28, 2003 at 22:15 UTC

    There's a difference between adressing problems of the code and addressing the problems of the coder. Which is I think what Ovid was referring to.

    For example, if I make a simple mistake in my code and you tell me it's because I need a haircut and a shave -- is that productive? Would it be better if you insult my intelligence or my education? I can, however, understand criticizing someone for not trying, and I can understand criticizing code for a multitude of reasons.

    I can tell you (this is a general "you", by the way) that you're wrong without being arrogant or abusive about it. But if you can't do the same for me then I don't think it's me that needs to grow up.

Re: Re: (OT) The Honest Cherry Bomb
by freddo411 (Chaplain) on May 29, 2003 at 18:35 UTC
    Bugfixes? If the code is stupid, and I say "Oh, you brilliant mind, what a wonderful code you've written", there's little chance the code will ever be fixed.

    Sorry, I fail to see what's wrong with a bit of honesty. If I say code is wrong when it is wrong, and I praise code when it's good, it's easy to know when I make a compliment, and when I think the code can be improved. From someone who's always nicey-nicey, you'd never know.

    Code is not stupid, stupid is an insult that applies directly to person you are addressing. Saying "This code is stupid" is most often heard as "You are stupid". Too often people think they are being "brutally honest" while in fact they are simply poor communicators, or to be "brutally honest", they are being stupid.

    Better ways to communicate:
    "This code doesn't meet the requirements."
    "The way this code is written is difficult for me to read."

    --------

    Nothing is too wonderful to be true -- Michael Faraday

      <pedantic>

      Code is not stupid, stupid is an insult that applies directly to person you are addressing.

      It's perfectly good English to refer to a thing as stupid without implying anything about the things author. Webster's has "Resulting from, or evincing, stupidity; formed without skill or genius; dull; heavy; -- said of things." as one of the definitions.

      Saying "This code is stupid" is most often heard as "You are stupid".

      All too true - but the problem may not be with the author. I can (and do :-) write stupid code on occasion, that doesn't imply that I am stupid.

      Too often people think they are being "brutally honest" while in fact they are simply poor communicators, or to be "brutally honest", they are being stupid.

      They might be poor communicators. They might not be stupid.

      </pedantic>