Use $ARGV[0] and $ARGV[1] instead of @ARGV[0] and @ARGV[1] also use crypt($_[0], $salt) rather than crypt(@_, $salt) | [reply]
[d/l]
[select] |
Try surrounding your code with the <code> tags
as suggested.
Here is a repost:
Any ideas why this will not work correctly? I've tried using it's generated password for Apache, Squid, and system logins and it won't work for any of them.
sub mkpasswd {
srand(time|$$);
$random = "abcdefghijklmnopqrstuvwxyz1234567890";
for (1..2) {
$salt .= substr($random,int(rand(36)),1);
}
return crypt (@_, $salt);
}
open(PWD,">>/some/file/used/for/apache/auth.txt");
print PWD "@ARGV[0]:" . mkpasswd(@ARGV[1]) . "\n";
close(PWD);
| [reply]
[d/l] |
To clarify what nardo said above, when you write:
@ARGV[0]
#instead of...
$ARGV[0]
You are confusing scalar and array contexts. The first line
(the way you did it) is actually an array slice, and perl
interprets it as a one element array. The second line tells
perl to treat it as a scalar value, that value being the first
element of the array. This is a common beginners mistake
(i used to do it) because it seems intuitive that arrays are
always preceeded by a @, whether you are indexing them or not.
However, once you understand what @, $, and % *really* do, it
will make sense. They tell perl what kind of value you are
talking about, and they also serve to select the namespace
(scalars, arrays, and hashes all have seperate namespaces).
If something is supposed to be a number, string, or other
scalar value, it has to have a $ in front of it. So, when you
index an array, you are selecting a scalar value out of the
array, so of course the expression must be preceeded by a $.
Hope this helps,
Mark | [reply]
[d/l] |