in reply to more efficient regular expression please
Assuming that I haven't screwed up again, which is by no means guarenteed, your regex doesn't quite catch all the cases.
Input cation.msgThe quick brown fox jumps over the lazy dog
Output caThe quick brown fox jumps over the lazy dog
However, that could be corrected. And the sad truth is that your version actually runs a tad faster than my (second) attempt, and also tye's offering, though the difference is marginal, and may fade once you correct the error.
The only saving grace is that mine is shorter and prettier, but then tye's is even shorter and prettier than mine, and runs a tad quicker to boot.
#! perl -slw use strict; use Benchmark qw[cmpthese]; # Set up some test data. my $text = 'The quick brown fox jumps over the lazy dog'; my @base_tests = map{ my $t = $text; substr($t, rand( length $text ), 0 ) = $_; $t; } map{ substr 'vacation.msg', $_ } 0 ..6; print "Before\n"; print for @base_tests; my @tests = @base_tests; s[((msg|vacation.msg)|a(cation.msg|t(ation.msg|ition.msg))|catation.ms +g|g|i(on.msg|tion.msg)|msg|n.msg|on.msg|sg|t(ation.msg|i(on.msg|tion. +msg))|vacation.msg)][] for @tests; print "\nAfter OP\n"; print for @tests; @tests = @base_tests; s[(?:(?:(?:(?:(?:(?:v?a)?c)?a)?t)?i)?o)?n.msg][] for @tests; print "\nAfter buk (second attempt)\n"; print for @tests; @tests = @base_tests; s[v?(a?(c?(a?(t?(i?(o?(n?(\.?(m?(s?g))))))))))][] for @tests; print "\nAfter tye\n"; print for @tests; cmpthese( -1, { OP => q[ my @tests = (@base_tests) x 100; s[((msg|vacation.msg)|a(cation.msg|t(ation.msg|ition.msg))|cat +ation.msg|g|i(on.msg|tion.msg)|msg|n.msg|on.msg|sg|t(ation.msg|i(on.m +sg|tion.msg))|vacation.msg)][] for @tests; ], buk2=> q[ my @tests = (@base_tests) x 100; s[(?:(?:(?:(?:(?:(?:v?a)?c)?a)?t)?i)?o)?n.msg][] for @tests; ], tye=> q[ my @tests = (@base_tests) x 100; s[v?(a?(c?(a?(t?(i?(o?(n?(\.?(m?(s?g))))))))))][] for @tests; ], }); __END__ P:\>junk Before The quick brown fox jumps overvacation.msg the lazy dog The quick brown acation.msgfox jumps over the lazy dog cation.msgThe quick brown fox jumps over the lazy dog The quick broation.msgwn fox jumps over the lazy dog The quick tion.msgbrown fox jumps over the lazy dog The quick brownion.msg fox jumps over the lazy dog The quick brown fox jumpson.msg over the lazy dog After OP The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog caThe quick brown fox jumps over the lazy dog The quick broawn fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog After buk (second attempt) The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog After tye The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog The quick brown fox jumps over the lazy dog Rate buk2 tye OP buk2 86806/s -- -3% -4% tye 89154/s 3% -- -1% OP 89993/s 4% 1% --
I'm taking a vacation as of now, from PM at least. It would be nice to take a real one, but that's not an option. I might be back someday.
|
|---|