Re: globalization sorrows

Mold->spawn:

sub spawn
{
   my $this=shift or die;
   my $class=ref($this) || $this;
   my $self = { };
   bless $self,$class;
   $self->{parent}=$self || die;
   $self->{mold}=$self || die;
   $self->init;
   return($self);
}
[download]

and Mold->init():

sub init
{
   my $self=shift;

   $SIG{__DIE__} = sub {endwin; };
   $SIG{__WARN__} = sub {
      endwin;
      warn @_;
      my $i = 0;
      while (my($pkg, $file, $line) = caller($i++)) {
         warn "  package $pkg, file $file, line $line\n";
      }
   };

   $self->{prefs} = Prefs->spawn($self);
   $self->{prefs}->load_rc();
   $self->{prefs}->load_terrains($self->{prefs}->{datadir} . "/terrain
+s");


   $self->{uic} = UI_Curses->spawn($self);
   $self->{com_int} = Command_Interpreter->spawn($self);
   $self->{grid} = Grid->spawn($self);
   $self->{com_proc} = Command_Processor->spawn($self);
   $self->{player} = Player->spawn($self);
   $self->{eq} = EventQueue->spawn($self);
   $self->{data_monsters} = Data::Monsters->spawn($self);
   $self->{msg} = Message->spawn($self);

   $self->{eq}->addclass('thingy');

}
[download]

now... see why i didn't want that thrown in? ;)

every one of those spawn commands use Standard.pm to inherit the spawn command.

And my goal is to stop passing along $self.

Comment on Re: globalization sorrows Select or Download Code

Replies are listed 'Best First'.
Re: Re: globalization sorrows by demerphq (Chancellor) on Jul 06, 2003 at 19:02 UTC
Look at the order of events here. BEFORE $main::mold gets assigned a value the following calls are made: `Mold::spawn Mold::init Prefs::spawn UI_Curses::spawn Command_Interpreter::spawn Grid::spawn Command_Processor::spawn Player::spawn EventQueue::spawn Data::Monsters::spawn Message::spawn` [download] So if any of those subs expect $main::mold to already have a value they would be wrong. Im guessing that you should either alter Mold::spawn so that it says `sub spawn { my $this=shift or die; my $class=ref($this) \|\| $this; my $self = bless {},$class; $main::mold=$self; $self->init() return($self); }` [download] Or remove the call to init() from the constructor and change the code in main to be `$mold=Mold->spawn; $mold->init();` [download] Also the self references that you put in there `$self->{parent}=$self \|\| die; $self->{mold}=$self \|\| die;` [download] will cause a memory leak unless they are eventually changed. A better design pattern for things like that is to use a pattern where the self referential structure is not itself the root object. Then the DESTORY method in the root object can safely remove the self references and the whole object will destruct when it falls out of scope. --- demerphq _{<Elian> And I do take a kind of perverse pleasure in having an OO assembly language...}	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Re: globalization sorrows
by demerphq (Chancellor) on Jul 06, 2003 at 19:02 UTC

Look at the order of events here. BEFORE $main::mold gets assigned a value the following calls are made:

Mold::spawn
Mold::init
Prefs::spawn
UI_Curses::spawn
Command_Interpreter::spawn
Grid::spawn
Command_Processor::spawn
Player::spawn
EventQueue::spawn
Data::Monsters::spawn
Message::spawn
[download]

So if any of those subs expect $main::mold to already have a value they would be wrong.

Im guessing that you should either alter Mold::spawn so that it says

sub spawn
{
   my $this=shift or die;
   my $class=ref($this) || $this;
   my $self = bless {},$class;
   $main::mold=$self;
   $self->init()
   return($self);
}
[download]

Or remove the call to init() from the constructor and change the code in main to be

$mold=Mold->spawn;
$mold->init();
[download]

Also the self references that you put in there

   $self->{parent}=$self || die;
   $self->{mold}=$self || die;
[download]

will cause a memory leak unless they are eventually changed.

A better design pattern for things like that is to use a pattern where the self referential structure is not itself the root object. Then the DESTORY method in the root object can safely remove the self references and the whole object will destruct when it falls out of scope.

_{<Elian> And I do take a kind of perverse pleasure in having an OO assembly language...}

[reply]
[d/l]
[select]