I also like printf, and your solution can also be written as:

printf "'%*s'\n",$margin,'x';
[download]

where the * means take the value from the next argument in the list, a feature which I've always found pretty handy.

--
I'd like to be able to assign to an luser