in reply to Re: Re: Reinvent a broken wheel?
in thread Reinvent a broken wheel?

You referred to yourself as a "borderline newbie/intermediate." Are you really sure the code he wrote was of low quality or did he just use certain constructs and idioms that you're just not familiar or comfortable with yet?

Either way, I as well would encourage you to go ahead and write your module, if for nothing other than the learning experience.

Replies are listed 'Best First'.
Re: Re: Re: Re: Reinvent a broken wheel?
by nysus (Parson) on Jul 08, 2003 at 22:02 UTC
    Well, when the module continutally tried to search http:/www.nytimes.com instead of http://www.nytimes.com, that was a pretty big tip off that the code wasn't up to snuff. The problem is that he rolled his own instead of using the URI module. Also, when I looked at the guts of the code, the 'new' constructor was 90% of the body of the code. That didn't smell quite right to me either. Then, to pass arugments, he would use code like

    sub _save_img { my ($self,$url,$img) = (shift,shift,shift,shift);

    Finally the code was littered with numerous #hack comments.

    I'm no expert mechanic true. But I do know that if the body is rusted and the interior is a filth pit (not that this code was THAT bad, mind you) there's a good chance the engine isn't worth repairing. I've seen enough professional code before and I know it when I see it. That doesn't mean I can write it.

    $PM = "Perl Monk's";
    $MCF = "Most Clueless Friar Abbot Bishop Pontiff";
    $nysus = $PM . $MCF;
    Click here if you love Perl Monks

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom