I'm just attempting to write a module and was wondering if it is bad practise to have subroutines within the module that don't *return* anything?

But your function is returning something. It is returning false if there is an error opening or closing the file, and true otherwise. Whether or not you use the return value is another matter...