in reply to Win32::Lanman

Not a very informative review, in my opinion. Neither was Programming Perl in the .NET Environment, but seeing as how it was your first, most of us went lightly. Please look over the existing Module Reviews to get a feel for which ones are good, and which ones are not. You don't have to go overboard like i did with my Lingua::Ispell review (that one was almost a tutorial), but you should at the very least try to include some sample code, like crenz's short but sweet review of Term::ProgressBar. Simply stating that you used the module with success is really not very helpful to others.

Put more effort in it, and get a lot more out of it.

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Replies are listed 'Best First'.
Re: (jeffa) Re: Win32::Lanman
by SyN/AcK (Scribe) on Jul 16, 2003 at 17:02 UTC
    Actually, I had looked at a few reviews, and I didn't see them include source code, so I didn't either. I will edit my post to include some sample source code then. As for the book review, I will take constructive criticism on that if you will post it. I thought it was good, but I'm only trying to be helpful here, so let me know what you'd like to see.
[reply]
      The best thing to do is sit down and read a lot of reviews. I was too ambiguous about code ... book reviews do not need to include code, but i think that module reviews benefit from good, easy to digest, cohesive code. There really are no rules for writing reviews for the Monastery, that's why i recommend that you read a lot of them and decide for yourself. As a bonus, you will learn a lot more than you probably ever wanted to know about Perl. ;) If you would like some recommendations, then check out ybiC's review of Data Munging and davorg's review of the mod_perl Cookbook. Steve_p even managed to get away with a review on a Java book. :D

      And as always, when in doubt, post your review to your scratch pad and politely ask the monks hanging around the Chatterbox to critique it.

      jeffa

      L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)
[reply]
        Yes, those are excellent suggestions, especially the last. So did it help that I put the code in here? I had hoped it would help. I put a link to the code sample I used, as well as my own code which was done in Visual Perl.NET. Thanks for the Input... I appreciate it.
[reply]
      There, that should be better.
[reply]

In Section Module Reviews