Re: Daft Regexp

Forgot to log in initially

#!wperl 

use IO::File;
use strict;

my $dir = $ARGV[0];
chomp($dir);
$dir =~ s{\\}{\\\\}g;

Recurse($dir);

sub Recurse
{
 my $handle = shift;
 opendir(SPROUT,$handle);
  my @entries = readdir(SPROUT);
 closedir(SPROUT);

 foreach my $i (2..scalar(@entries))
 {
  my $param_handle = $handle."\\".$entries[$i];
  if(opendir(TEST,$param_handle) and $entries[$i])
  {
   closedir(TEST);
   $handle =~ s{\\\\}{\\}g;
   my ($newdirname)= $handle."\\".$entries[$i];
   $newdirname =~ s/^([a-z])/\u$1/g;
   rename ($handle."\\".$entries[$i], $newdirname);
   Recurse($newdirname);
  }
  elsif ($entries[$i])
  {
   my ($newname) =$handle."\\".$entries[$i];
   $newname =~ s/^([a-z])/\u$1/g;
   rename ($handle."\\".$entries[$i], $newname);
  }
 }
}
[download]

And it doesn't seem to capitalise the first letter of dirs, and files... Could it be something else in the script?
cheers
ant

Comment on Re: Daft Regexp Download Code

Replies are listed 'Best First'.
Re: Re: Daft Regexp by jsprat (Curate) on Aug 05, 2003 at 01:21 UTC
The problem is not the regex. Take a look at the values of $newname and $newdirname and the error messages. Look at the ouptut after adding `rename ... or die "Error renaming $newname: $!"; #use $newdirname where appropriate` to each rename statement. Since you are renaming _every_ file and directory, the whole rename sequence is practically begging to be taken out of the if/elsif statement. PS: You probably want to take a look at File::Find	[reply] [d/l]
Re: Re: Daft Regexp by waswas-fng (Curate) on Aug 05, 2003 at 07:41 UTC
Try using File::Find and doing a depth first search, its usually better practice (less error prone) to start renaming from the deepest part of the tree twords the top IMHO. -Waswas	[reply]