"The Colour of Magic" is really not representative of Discworld. Quite a lot of PTerry's books have really good elves, "Lords and Ladies", "The Fifth Elephant" and "The Wee Free Men" to name just a few.

Of course when I say good I don't mean good