in reply to Re: Improvement on script needed.
in thread Improvement on script needed.

Good use of a "seen" hash, asarih, but i have to say that i would rather use this: 
my ($value,$key) = $_ =~ /^([^\|]+)\|(.*)/;

[download]
than explicitly "spell out" $1 and $2. But if all you want to do is split at the first pipe, just use split: 
my ($key,$value) = split(/\|/,$_,2);
next if $seen{$value};
print "$key: $value\n";
$seen{$value}++;

[download]
I don't have time for some benchmarking right now, but substr and index are fast: 
my $index = index($_,'|');
my $key   = substr($_,0,$index);
my $value = substr($_,$index);

[download]
Just some more ways to do it. ;)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Replies are listed 'Best First'.
Re: 2Re: Improvement on script needed.
by Anonymous Monk on Sep 08, 2003 at 14:58 UTC
    I tried as suggested but cant get your new script to work on my text file. Please advise what Iam doing wrong. Thanks. 
    my $db = 'C:\Inetpub\wwwroot\cgi-bin\test4.txt';
open(DATA, "$db") || die "Can not open: $!\n";
my @dat = (<DATA>);
close(DATA);
open(DATA, "$db") || die "NO GO: $!\n";
my %seen;
while (<DATA>){
my ($value,$key) = $_ =~ /^([^\|]+)\|(.*)/;
my ($key,$value) = split(/\|/,$_,2);
next if $seen{$value};
print "$key: $value\n";
push(@files,$key);
my @files = (<DATA>);
print DATA @files;
$seen{$value}++;

}


close(DATA);

    [download]
[reply]
[d/l]
      You shouldn't read DATA inside the while loop. In the first iteration of the while loop, 
      my @files = (<DATA>);

      [download]
      sucks up what's left in DATA and the loop terminates.
[reply]
[d/l]

In Section Seekers of Perl Wisdom