Re: Static Data ("__DATA__" vs. "our") (handles)

If you use __DATA__ in a module, then please be careful to close DATA soon after the module is first required.

Otherwise you are tying up one of the process's finite supply of file handles. It is easy for a Perl script to use a lot more modules than it does file handles, so this has the potential to be a big problem.

- tye

Comment on Re: Static Data ("__DATA__" vs. "our") (handles) Download Code

Replies are listed 'Best First'.
Re: Re: Static Data ("__DATA__" vs. "our") (handles) by IlyaM (Parson) on Sep 18, 2003 at 19:30 UTC
Another common problem I've seen with usage of __DATA__ in modules is using `while(<DATA>)` without localizing `$_` (see while(<>) { ... } considered harmful why it is bad). Update: Actually `$_` should not be used in modules at all. See this bug report why. -- Ilya Martynov, ilya@iponweb.net CTO IPonWEB (UK) Ltd Quality Perl Programming and Unix Support UK managed @ offshore prices - http://www.iponweb.net Personal website - http://martynov.org	[reply] [d/l] [select]

Replies are listed 'Best First'.

Re: Re: Static Data ("__DATA__" vs. "our") (handles)
by IlyaM (Parson) on Sep 18, 2003 at 19:30 UTC

while(<DATA>)

local

$_

while(<>) { ... } considered harmful

Update: Actually $_ should not be used in modules at all. See this bug report why.

--
Ilya Martynov, ilya@iponweb.net
CTO IPonWEB (UK) Ltd
Quality Perl Programming and Unix Support UK managed @ offshore prices - http://www.iponweb.net
Personal website - http://martynov.org

[reply]
[d/l]
[select]