Is this a good way to go for a recursive sub?

Generally accepted answer: no. Use File::Find, which is a standard module, or maybe File::Find::Rule, which many people seem to prefer — I don't know it personally, but I thought I'd mention it anyway, otherwise there is bound to be a follow-up to this post pointing to it. :)