Re: Recursive sub

The first problem is that the code you posted doesn't compile:

P:\test>perl -c -mstrict -w junk.pl
Scalar value @_[0] better written as $_[0] at junk.pl line 6.
syntax error at junk.pl line 5, near "sub recurseDir2 "
Can't use global @_ in "my" at junk.pl line 6, near "glob @_"
syntax error at junk.pl line 17, near "}"
junk.pl had compilation errors.
[download]

If you correct the missing semicolon on the first line, the use of @_[0] instead of $_[0] in the third and the ommission of the '2' in the subname in the 7th line, it appears to work fine.

Adding -w and use strict isn't obligatory, but it would probably have saved your need to post this question.

#! perl -w
use strict;

my $dir = "C:/";

sub recurseDir2 {
    my @temp = (glob $_[0]);
    foreach (@temp) {
        if (-d $_) {
            print "Directory: $_" , "\n" ;
            recurseDir2("$_/*");
        }else{
            if (-f $_) {
                print "File: $_ \n";
            }
        }
    }
}
recurseDir2($dir)
[download]

Examine what is said, not who speaks.

"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller
If I understand your problem, I can solve it! Of course, the same can be said for you.

Comment on Re: Recursive sub Select or Download Code

Replies are listed 'Best First'.
Re: Re: Recursive sub by pen (Acolyte) on Sep 23, 2003 at 19:40 UTC
All good stuff. The missing ellements were typos as I posted from another machine and couldn't cut and paste. I have not seen this before `#! perl -w` where can I find information on this. It is commented out as well so how can it do anything? Paul Neale	[reply] [d/l]
Re: Re: Re: Recursive sub by BrowserUk (Patriarch) on Sep 23, 2003 at 20:39 UTC
It's often called the shebang line, and is mostly used on unix systems to tell the shell where it should look for the perl binary. Windows doesn't use this mechanism to find the binary, so that use is mute. However, if the line is present, perl will inspect it and respect (some of) the runtime switches (see Perlrun). I use it as a "reminder" for switches that I have permenantly enabled through the assoc/ftype mechanism (-sw) --mostly so people can see what I use when I post code. I also use it to enabled individual switches on a case by case basis. The most frequent one being -l as it save me having to add "\n" to the end of every print line. Of course, there are times when you don't want a newline printed, in which case I just use `printf $string;` instead. Works for me:) Examine what is said, not who speaks. "Efficiency is intelligent laziness." -David Dunham "When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller If I understand your problem, I can solve it! Of course, the same can be said for you.	[reply] [d/l]
Re: Re: Recursive sub by pen (Acolyte) on Sep 23, 2003 at 19:47 UTC
I just tried use strict and it stops everything from printing. Should this happen? Paul Neale	[reply]
Re: Re: Re: Recursive sub by BrowserUk (Patriarch) on Sep 23, 2003 at 21:03 UTC
No. `use strict;` shouldn't stop everything from printing...and it doesn't on my system. I suspect that you are running your script from the Explorer by double clicking and the reason you see no output is because you have a compilation error that prevents your script reaching the sleep statement and so the window is disappearing before you have a chance to read the error messages produced. I would advise you to start using the command line, at least for testing your scripts. Examine what is said, not who speaks. "Efficiency is intelligent laziness." -David Dunham "When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller If I understand your problem, I can solve it! Of course, the same can be said for you.	[reply] [d/l]
Re: Re: Re: Re: Recursive sub by pen (Acolyte) on Sep 24, 2003 at 00:14 UTC
Hmm, I am using the command line. I'll keep playing. I have a long way to go and that is the least of my problems. I think I'll go order a book;) Paul Neale	[reply]