in reply to Request for Comment on OTRS

I looked at the code briefly and I noticed a few things you should concern yourself with.

Here's a code snipped from the index.pl:

my $User = $CommonObject{ParamObject}->GetParam(Param => 'User') || ' +'; my $Pw = $CommonObject{ParamObject}->GetParam(Param => 'Password') + || '';
I don't know about you but this seems like a hell of a lot of overhead to get a darn username and password! The CGI stuff should be a higher level object rather than nested down so far. Looking randomly at other code makes me think that OO programming went to some kind of extreme here. Perhaps the developers are used to another language?

Also, if I am right and the index.pl file is the starting point for this program (didn't have enough time to read the DOCS, sorry!) then it is NOT running in taint mode, which is not a problem if you are doing all of the stuff that taint mode insists that you do, but somehow I don't think that it is the case here. You are welcome to check for youself though.

#!/usr/bin/perl -wT #where art thou?
Lastly, there are tons of .DTL files which looks like some kind of proprietary version of Embperl. I probably would have just used Embperl instead unless there was a good reason not to use it.

Celebrate Intellectual Diversity

Replies are listed 'Best First'.
Re: Re: Request for Comment on OTRS
by HyperZonk (Friar) on Sep 30, 2003 at 00:46 UTC
    InfiniteSilence:

    Thanks for taking the time to look at it! Actually, I was hoping for feedback from someone who had already taken the time and/or implemented it, as the codebase is far too large for a really thorough review on such short notice.

    Still, your comments are helpful. I'd say I was just going to add my own -T, but we'll have to see if that breaks anything or not (if we decide to use it).


    -HZ