Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

I am going nuts trying to figure out why the following code doesn't work

!/usr/bin/perl -w use strict; my $dir="/var/www/html/datadir"; # opendir (DIR, $dir) or die "cannot open $dir"; foreach my $file (readdir(DIR)) { &process_file ($file); } closedir (DIR); sub process_file { my $mm="01"; my $yyyy="2000"; do { print "MM: $mm\n\n"; # for troubleshooting my $yyyymm=$yyyy.$mm; print "YYYYMM: $yyyymm\n\n"; # for troubleshooting my $midxnme="index_$yyyymm.txt"; print "MIDXNME: $midxnme\n\n"; # for troubleshooting my $midxfle="$search_data_dir/$midxnme"; if($midxfle = my $file) { print "found $midxfle\n"; } else { system ("command"); } $mm++; print "\n\nMMnext: $mm\n\n"; # for troubleshooting } while ($mm <= "12"); }

On the lines where I print out for troubleshooting the MM stays at 01 on the first one and for MMnext it goes to 02 but it just stays in that particular loop. Also, even if the $midxfle file exists it always goes to the system("command").

I need the MM to increment by 1 each time until it reaches 12. What am I doing wrong?

Replies are listed 'Best First'.
Re: do while debacle
by Abigail-II (Bishop) on Oct 09, 2003 at 16:07 UTC
    If I run this the last line it prints is 'MMnext: 13'. Prints lots of warnings though.

    Also, even if the $midxfle file exists it always goes to the system("command").
    Well, yeah, that's because your if test is like:
    if($midxfle = my $file)
    $file is a new variable, whose value is undefined. You assign that to $midxfle, so the result of the entire expression is false.

    Abigail

Re: do while debacle
by kutsu (Priest) on Oct 09, 2003 at 18:04 UTC

    If all your trying to do is to check if those files exist

    if($midxfle = my $file) {
    might be better as
    if (-s $midxfle) {

    -s = exist and with size greater than 0, -e = exist any size

    "Pain is weakness leaving the body, I find myself in pain everyday" -me

Re: do while debacle
by diotalevi (Canon) on Oct 09, 2003 at 16:36 UTC

    To expand on Abigail-II, you need to sub process_file { my $file = shift; .... if ( $midxfile eq $file ) ... instead of that jobby you wrote.

Re: do while debacle
by freddo411 (Chaplain) on Oct 09, 2003 at 18:03 UTC
    Although the practical effects in this case are harmless, but you definitely dont' want to do a test like you have:
    while ($mm <= "12");
    "12" is a string and you really want a number like 12. Perl will magically change the string "12" into the number 12.

    Cheers.

    -------------------------------------
    Nothing is too wonderful to be true
    -- Michael Faraday