Using a leading "r_" on references can help to keep track of things, mnemonic-wise:

 sub makeSql {
   my $r_xpid = shift;
   my $return = "";

   $return .= $r_xpid->[$_]
       foreach 0 .. scalar @$r_xpid - 1;
    return $return;
 }
[download]