File Uploading

etzel42 has asked for the wisdom of the Perl Monks concerning the following question:

I am having trouble with uploading (.mp3) files that are about 3MB in size or bigger. The below code works great until I try to upload a large file. Any thoughts?

use CGI;
sub doUpload {
my ($buffer);
$query = new CGI;

$filename = $query->param("file");
$filename =~ s/.*[\/\\](.*)/$1/;
$myupload = $query->upload("file");

if ($filename =~ /.mp3/) {
  open (UPLOADFILE, ">$dirpath/$filename");
    while (read($myupload, $buffer, 1024)) {
      print UPLOADFILE $buffer;
    }
  close (UPLOADFILE);
}

print "Location: $cgipath?action=success\nURI: $cgipath?action=success
+\n\n";
}
[download]

I have also tried it this way:

if ($filename =~ /.mp3/) {
  open (UPLOADFILE, ">$dirpath/$filename");
    while ( <$myupload> ) {
      print UPLOADFILE;
    }
  close (UPLOADFILE);
}
[download]

Thanks.

-----------------------
[download]

I thought I got it working, but I didn't. It's not creating a file at all. I added this to it:

$CGI::POST_MAX = 102400;
[download]

or 100MB. How do I check the return value of "OPEN"?

Comment on File Uploading Select or Download Code

Replies are listed 'Best First'.
Re: File Uploading by mandog (Curate) on Oct 15, 2003 at 22:23 UTC
You might add some more error checking for example: `use strict;` and... `open (UPLOADFILE, ">$dirpath/$filename") or die "bad open $dirpath/$filename\n $!";` [download] You might look at CGI::POST_MAX Your system admin may have set it in CGI.pm `perldoc CGI # skip some stuff $CGI::POST_MAX If set to a non-negative integer, this variable puts a ceiling on the size of POSTings, in bytes. If CGI.pm detects a POST that is greater than the ceiling, it will immediately exit with an error message. This value will affect both ordinary POSTs and multipart POSTs, meaning that it limits the maximum size of file uploads as well. You should set this to a reasonably high value, such as 1 megabyte.` [download] email: mandog	[reply] [d/l] [select]
Re: File Uploading by vek (Prior) on Oct 16, 2003 at 17:04 UTC
You should always check the return val of `open` to make sure you have created the file. Are you sure the file is being created? Are you left with a zero byte size file or no file at all? If you have no file at all then you had a problem creating the file. If you have a zero byte size file then that would sugget `CGI::POST_MAX` issues. -- vek --	[reply] [d/l] [select]