To create the string, use join, as in:

  my $string = join('&&', @Product) 
             . ' -'
             . join('&&', @State);
[download]

If create is a function, then

  create($string);
[download]

-QM
--
Quantum Mechanics: The dreams stuff is made of