You are correct in that the OP has code that meets
dragonchild's First Criterion of Good Coding. However, I would actually argue that the OP
should convert to
Win32::IPConfig, for the following reasons:
- OP would learn more about the Win32:: namespace
- OP would learn why it is useful to use said namespace
- Maintainer(s) (which might include OP) won't have to deal with hand-rolled code (and the bugs that go with no peer review)
- If ipconfig changes (as it probably will), Win32::IPConfig will (should?) change with it
- Should ipconfig be different on different Win32 machines, Win32::IPConfig will (should?) handle that transparently
Those reasons boil down to meeting the Second Criterion of Good Coding.
- Code should do what it needs to do.
- Code should be both easy and safe to modify.
- Code that meets #1, no matter how poorly written, is "good".
- Code that meets both #1 and #2 is "great".
- Code that meets #2, but not #1, is worthless.
------
We are the carpenters and bricklayers of the Information Age.
Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.