in reply to Evaluate my news retriever... (pretty please!)

Just a few general things to start with,

  1. You would do better to parse XML with something from cpan's XML offerings.
  2. Your sql would benefit from placeholders.
  3. Your time-of-day handling could be cut to nothing with &POSIX::strftime.
  4. Try doing this with taint mode on. Some checking of results might be wise.

After Compline,
Zaxo

  • Comment on Re: Evaluate my news retriever... (pretty please!)