in reply to Simple ZIP extractor

Nice piece of simple code, but I'd like to add just a few lines to make the error handling a little nicer if the file in @ARGV doesn't exist ;)

Right now, if I use a non existant file I get a lot of irrelevant (for the user) data:

$ ./unzipper nonexistant.zip IO error: opening nonexistant.zip for read : No such file or directory + Archive::Zip::Archive::read('Archive::Zip::Archive=HASH(0x8120 +258)','nonexistant.zip') called at /usr/local/lib/perl5/site_perl/5.8 +.0/Archive/Zip.pm line 522 Archive::Zip::Archive::new('Archive::Zip::Archive','nonexistan +t.zip') called at /usr/local/lib/perl5/site_perl/5.8.0/Archive/Zip.pm + line 211 Archive::Zip::new('Archive::Zip','nonexistant.zip') called at +./unzipper line 6 Unable to open nonexistant.zip: at ./unzipper line 6.

This can be solved by just a few extra lines:

#!/usr/bin/perl -w use Archive::Zip; for (@ARGV) { if(! -r $_) { print "$_: $!\n"; exit 1; } print "Unzipping: $_\n" if $debug; my $zip = Archive::Zip->new($_) or die "Unable to open $_: $!"; for my $m ($zip->members()) { print " Member: ".Dumper($m)."\n" if $debug; # $m is an object of class Archive::Zip::ZipFileMember print " ".$m->fileName()."$/"; $zip->extractMember($m); } }

Now the error will be slightly more helpful to l-users

$ ./unzipper nonexistant.zip nonexistant.zip: No such file or directory
--
b10m

Replies are listed 'Best First'.
Re: Simple ZIP extractor
by jonadab (Parson) on Dec 25, 2003 at 13:01 UTC
    Right now, if I use a non existant file I get a lot of irrelevant (for the user) data:

    Yes, quite so. My script wasn't intended to be used at the command-line, but to be associated with the ZIP filetype in Windows Explorer, for double-click unzipping. A real command-line zipfile utility would need some additional functionality.


    $;=sub{$/};@;=map{my($a,$b)=($_,$;);$;=sub{$a.$b->()}} split//,".rekcah lreP rehtona tsuJ";$\=$ ;->();print$/