Re: Need some testers/Input
by Old_Gray_Bear (Bishop) on Dec 29, 2003 at 00:47 UTC
|
Neat.
Right off the top --
- How do I change the color scheme? (I know, hack the code. But the colors really should be in a configuration file.)
- Ditto, the font. (Again, I can mod the code, but putting meta-data like colours and fonts into a config-file is really better in the long run. More maintainable -- changing your code should not effect my custom settings.)
- Maybe allow the User to specify which key words get which colour. (I know I am building an enormous config file. But you can group things and set default colors that the user can over ride. For example -- "subroutine => 'yellow'; "subroutine this_sub => 'orange'" in the config-file will highlight all subroutine names in yellow except 'this_sub'.)
- Would it be useful to highlight packages when they are used in identifiers -- $My::Package::new() gets "My::Package::" in 'medium-yellow' and "new()" gets rendered in 'bright-yellow". It will be gaudy, but my production code is littered with these constructs. It often gets hard to find the subroutine for all of the package qualification. (my $next_curve_ref = $estimate -> Statistics::Kerman::NonLinear::Approximation::Regression::CubicSpline::new() for example.)
- It would be very useful to have the current line number displayed. (And updated as the cursor moves.)
- Have you thought about highlighting opening and closing braces? (Brackets and Parenthesis are less likely to find themselves separated by a couple dozen lines. (An aside; I have just ran across a production module last week where the line number of the opening brace is 110 and the closing brace is on line 1044; one hulluva 'if' statement. Major refactoring project, starting tomorrow...)
Are you in position to accept patches?
----
I Go Back to Sleep, Now.
OGB
| [reply] |
|
|
| [reply] |
Re: Need some testers/Input
by ysth (Canon) on Dec 28, 2003 at 22:32 UTC
|
Why a binary executable? And what is that strange .zip extension file (just kidding, but it has been a very long time since I had to unzip anything).
The readme on the website is vague about licensing. There are two (that I know of) flavors of GNU licenses and multiple versions. You should specify more clearly which you mean.
Update: I note that the .exe is more than 100 times the size of the .pl file. For those that do have Tk and perl,
perhaps you could distribute the source separately? | [reply] |
|
|
| [reply] |
Re: Need some testers/Input
by b10m (Vicar) on Dec 29, 2003 at 11:05 UTC
|
Couple of things here :
- Like others have posted, seperate the executable, for it is useless for non-win32 users, yet it's 2.2M.
- I would like to see more coloring, like variables, brackets, parens etc.
- Also I'd like to note that the comments (gray) are barely readable due to the background. It'd be cool to be able to set the colors yourself. And I find the choice of red for print commands quite odd, but that's all personal preference. (I see red as an error)
- When/if you implent the color preference choose dialog, please include an option to change the font size too, for I find it quite big.
- I wondered why my scripts were "not recognized as a valid Perl script", when pressing the "Run Script!" button, but the source showed me that's because I (almost) never use a .pl extension. Why did you choose for such a test?
| [reply] |
Re: Need some testers/Input
by PodMaster (Abbot) on Dec 29, 2003 at 13:06 UTC
|
I have removed the pEdit.exe and recompressed the program as
pEdit.tar.bz2, only ~12k.
Now for the comments
- missing features:
- No help :)
which is probably because you have no menus (or a proper toolbar)
- There are no keyboard shortcuts (they go well with menus)
You should really take what you have so far and incorporate it into "gedi" which comes with the Tk distribution. PS - apparently the current version of gedi needs patching.
- Pod is not hilighted at all (super fancy hilighting like jEdit does is not neccessary, merely doing as vim does is fine -- the difference is jEdit hilights pod =headN differently from =for...)
- bugs
- Total lines doesn't work if you're just working with a buffer
- Goto lines doesn't work if you're just working with a buffer
- Find doesn't work if you're just working with a buffer
- Run Script! doesn't work if you're just working with a buffer (Error! No script was provided to run)
- Color Text? wipes out the buffer if you're working with a buffer (this is not cool).
- Test Syntaxt! works ok with just a buffer.
| MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!" | | I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README). | | ** The third rule of perl club is a statement of fact: pod is sexy. |
| [reply] |
|
|
Couple of responses:
- I did not use menues or toolbars as of yet because I am not entirely sure I like their appearance in Tk. Actially I know that I do not like their appearance.
- As far as keyboard shortcuts I have created a few custom binding. Are you saying their is no place that lists thge shortcuts? Like in a help dialog?
- I agree the exe is quiet large, maybe I will seperate the 2 downloads, one the source and the other the executable.
- About the bug fixes. What do you mean with regards to "working with a buffer"?
| [reply] |
|
|
I did not use menues or toolbars as of yet because I am not entirely sure I like their appearance in Tk. Actially I know that I do not like their appearance.
But they look like standard menus... you're just reinventing a toolbar without images... users of your product would appreciate them.
As far as keyboard shortcuts I have created a few custom binding. Are you saying their is no place that lists thge shortcuts? Like in a help dialog?
Yes, there is no place that lists them (like a help dialog),
and the critical ones are missing (Ctrl+O for open, Ctrl+S for save...)
What do you mean with regards to "working with a buffer"?
I click the New/Clear button. I type. I don't click the save or save as buttons.
What do I have? That's right, an in memory buffer (probably a Tk::Text object).
| MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!" | | I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README). | | ** The third rule of perl club is a statement of fact: pod is sexy. |
| [reply] |
|
|