in reply to Re: Re: Re: Code for elegance, code for clarity
in thread Code for elegance, code for clarity

I have a great deal of respect for people who can walk into a code review and look at their own code objectively as community property.
As do I. Really, I do. Unfortunately, people tend to take it personally sometimes, especially in some languages where code style borders on religion (which is why I speak of Java). I would love to see fair and unbiased code reviews, but you can't do that when the group is not a meritocracy, but rather ruled on seniority and posturing. Having meetings to question code quality can get very ugly unless everyone is on good terms and is in it for the good of the group not the individual. I want the former, but I have been unable to find it (sad, actually).
  • Comment on Re: Re: Re: Re: Code for elegance, code for clarity

Replies are listed 'Best First'.
Re: ^4 Code for elegance, code for clarity
by mcogan1966 (Monk) on Jan 14, 2004 at 20:46 UTC
    I have a great deal of respect for people who can walk into a code review and look at their own code objectively as community property.
    I had to.

    I was doing Y2K work at the time. The code I wrote wasn't really mine anyway. So, code review was the final acid test to see if what I was sending out was actually correct in every way and didn't cause any problems. In that environment, you quickly learn to disassociate yourself from your work. Otherwise, every question on the code can feel like a personal attack. I've watched that happen too.