Which of these two versions of similarly functional functions is "more efficient" in your opinion and why? Thanks!

use strict;

# Using regex
sub trimall_v1 {
    # Trims all extra whitespace from left, right and middle!
    my @out=@_;  # Pass by value!
    for (@out) {
        s/^\s+//;
        s/\s+$//;
        s/\s+/ /g;
    }
    return wantarray ? @out : $out[0];
}

# Using specialized split on ' ' and $_
sub trimall_v2 {
    # Trims all extra whitespace from left, right and middle!
    my @out=@_;  # Pass by value
    for (@out) {$_= join ' ',split;}
    return wantarray ? @out : $out[0];
}

my $val="   Scalar  \r\r\n\t\t\n  ";
my @list=("  List\t\t\n 1 \n \n    \n"," \t\t List 2  ","  List\t\t\t\
+n 3\t\n\n\r  ");

print "'$_'\n" for (trimall_v1($val));
print "'$_'\n" for (trimall_v1(@list));

print "'$_'\n" for (trimall_v2($val));
print "'$_'\n" for (trimall_v2(@list));
__END__

[download]

In reply to regex verses join/split by aquacade

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.