There are actually only two little things that keep your code from working:
  1. You declare (and unnecessarily clear) %ips inside the loop.
  2. You assign the line contents to $ips{$site} instead of incrementing a counter there. $ips{$site}++ is fine---if the element doesn't exist, it will read as undef which in numeric context is a zero.

I don't know how big your logs are but another thing you could do is improve that regexp: be as specific as you can about each field. At the very least that means specifying a non-blank character where you need one/ On my machine, parsing a typical log line with your version takes about 5.2µs; if I change $w to /(\S+?)/, it's just about 0.9µs. Adding an /o flag to only have it interpolate and compile the regexp once brings it down to 0.35µs. I'm not sure why the difference is so big as there's not that much backtracking¹ but anyway it helps. I didn't benchmark whether it makes a speed difference but the assignment is much shorter to write as follows: 

my ($site, $logName, $fullName, $date, $time, $gmt, $req, $file, $prot
+o, $status, $length) =
$line =~ /^$w .../o;

[download]

¹ Using $w = "(.+)" which really backtracks lot takes a whopping 185µs per line.

In reply to Re: unique visitors from html logfile by mbethke
in thread unique visitors from html logfile by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.