I cannot figure out how to fix these issues.

Buy the book, then you might stand a chance :) 

$ pm_which Perl::Critic
C:\perl\site\5.14.1\lib\Perl\Critic.pm

$ ack "Useless interpolation of literal string" C:\perl\site\5.14.1\li
+b\Perl\Critic
C:\perl\site\5.14.1\lib\Perl\Critic\Policy\ValuesAndExpressions\Prohib
+itInterpolationOfLiterals.pm
24:Readonly::Scalar my $DESC => q{Useless interpolation of literal str
+ing};

[download]

perldoc Perl::Critic::Policy::ValuesAndExpressions::ProhibitInterpolationOfLiterals

I am not a fan of this policy :)

Also, since essentially these functions are doing the same thing (one with variables and one with lists), is there a way to combine them where it wouldn't matter if variables or arrays are passed?

What is the purpose of these functions? Your use of string-eval could be critical :)

In reply to Re: Perl::Critic and Subroutines by Anonymous Monk
in thread Perl::Critic and Subroutines by daugh016

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.