Hi, I am no perl programmer however I need to create a script that creates a desired number of tables with desired number of inserts per table, here is the code : 
#!/usr/bin/perl
use DBI;

$tables=100;
$rows=10000;
$count=1

if (!($dbh = DBI->connect ('DBI:Oracle:orcl',"hr","hr")))
{
die ("Failed to connect to database: " . DBI->errstr);
};

$sql = "CREATE TABLE test_data($count)(".
            "id PRIMARY KEY,".   
            "group_id NOT NULL,".
            "created_at NOT NULL,".
            "text NOT NULL) AS ".
                    "SELECT ".
                        "rownum,".
                        "MOD(rownum, 5),".
                        "TO_DATE('1-jan-07', 'dd-mon-yy') + INTERVAL '
+1' MINUTE * rownum,".
                        "CAST ('xyz' || rownum AS VARCHAR2(50)) ".
                    "FROM dual ".
                    "CONNECT BY LEVEL <= $rows";


while ($count<$tables)
{
if (!($dbh->do ($sql)))
{
die ("Failed to insert row: " . DBI->errstr);
};

 $count++;
}
$dbh->commit;

$dbh->disconnect;

[download]

It should create tables from test_data1 to test_data100

Can someone be please kind enough to correct the code.

Thank you very much in advance.

Rgds

Terry

In reply to Need help to correct a simple script by terrykhatri531

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.