You shouldn't have that inner while. I'd just make it 

if ( $line =~ $ip ) {
    push (@fwlog, $line);
    print "$line";
}

[download]

or equivalent.

You might also try changing that final print to read 

print "$_\n" foreach ( @fwlog );

[download]

but you should be getting *some* output.

An alternate approach: if the file isn't really large, you could suck it into memory and put the matching lines into an array, á la: 

open LOG,  "$logfile" or die "Can't open $logfile: $!\n";
my @fwlog = grep { $ip } <LOG>;
close LOG;

[download]

that grep line will grab just the lines from the file that match. To remove the newlines from those, you can just chomp the whole array.

Finally, note that the "." has special meaning. That regex will match "192a168b3c5", so to make sure you're just getting the IP you're looking for, escape those dots.

HTH! 

perl -e 'print "How sweet does a rose smell? "; chomp ($n = <STDIN>); 
+$rose = "smells sweet to degree $n"; *other_name = *rose; print "$oth
+er_name\n"'

[download]

In reply to Re: Saving Results of a while loop by arturo
in thread Saving Results of a while loop by dru145

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.