The main problem of your code has been solved. However, there are lots of other things that can be improved:
- Use the 3 argument version of open with lexical filehandles. Also, the open or die idiom is much more readable and common than your unless structure.
- Do not use the same name for various types of things (scalar and array variable in this case).
- If you can process the file line by line, do not slurp it all into memory.
- Use hashes to count numbers of occurrences.
Here is how I would approach your problem:
#!/usr/bin/perl
use strict;
use warnings;
print "Enter the file containing the sequence: ";
my $filename = <STDIN>;
chomp $filename;
open my $FH, '<', $filename or die "Cannot open $filename: $!";
my @chars = qw(A C D E F G H I K L M N P Q R S T V W Y);
my $length;
my $char_regex = join q(), @chars;
$char_regex = qr/[$char_regex]/;
my %occ;
while (my $line = <$FH>)
{
for my $char (split //, $line)
{
next unless $char =~ $char_regex;
$length++;
$occ{$char}++;
}
}
print "AMINO ACID \t OCCURRENCE \t FREQUENCY\n";
for my $char (@chars)
{
$occ{$char} //= 0;
print "$char \t\t $occ{$char} \t\t ", $occ{$char} / $length, "\n"
+;
}
BTW, the plus sign at 'S' just means your line is too long and has been wrapped. You can adjust your line length in your settings.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.