You don't say exactly what's wrong with it. I didn't see any obvious bug in the code you commented out and I don't want to spend the time testing your code when you simply could tell us what exactly was wrong with it.

But I can tell you that you won't have a great performance anyway if you reread the one file once for every one of the many files as you seem to be doing.

If that one file fits into your memory, better read it first (and only once) and keep it in an array or hash.

If it doesn't fit you could create a hash on disk (for example with the help of a module like DBM::Deep) with a key made out of the comma-separated concatenation of x,y and z).

In reply to Re: Hello im new to programming i need help by jethro
in thread Hello im new to programming i need help by fahadm89

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.