- Do not use parse (), use getline ()
- Use a lexical file handle
- Never use an else branch if the if branch ends the enclosing scope (exit, return, die, last, …)
- Use auto_diag
- Use positive logic for validation
# Use auto_diag to see all parsing errors immediately
my $csv = Text::CSV_XS->new ({ binary => 1, auto_diag => 1, allow_whit
+espace => 1 });
open my $fh, "<", $file_to_parse or die "Could not open '$file' $!";
while (my $row = $csv->getline ($fh)) {
# Check first and third field to be numeric only (and not empty)
$row->[0] =~ m/^[0-9]+$/ && $row->[2] =~ m/^[0-9]+$/ or
exit; # wrong format
# THERE CANNOT BE AN ELSE AFTER AN EXIT !
}
update: your sample data contains spaces. You will have to deal with those, as the current tests will fail for leading and training spaces. Adding allow_whitespace option to the constructor will help you here.
Enjoy, Have FUN! H.Merijn
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.