You ran into a pet peeve of mine (at least twice in presented code):

There shall be no else after leaving enclosing scope (exit, die, return, last …)

When using if … else …, the code after that is to be executed always, that is why you have if/else. If however the first part ENDs with an exit of the enclosing scope, there is no need whatsoever for the else. Removing else, the braces and the indent, make the code easier to read and maintain.

if (expression) {
    …
    exit;
    }
else {
    …
    …
    }

=>

if (expression) {
    …
    exit;
    }

…
…

[download]

See for slides from a talk here and here/here:

sub foo
{
    my $s = shift;

    if (defined $s) {

        if ($s ne "") {
            #
            # 150 lines of code
            #
            }
        else {
            die "String is empty";
            }
        }
    else {
        die "String is null";
        }
    }

=>

sub foo
{
    my $s = shift;

    unless (defined $s) {
        die "String is null";
        }

    if ($s eq "") {
        die "String is empty";
        }

    #
    # 150 lines of code
    #
    }

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re: Perl replacement for choice.com by Tux
in thread Perl replacement for choice.com by onelander

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.