And of course once you have done that you will be able to move the prepare outside the loop while keeping the execute inside the loop. This is where a lot of the efficiency of prepared statement handles comes in.

$query = $dbh->prepare('INSERT INTO products_attributes (products_id, 
+options_id, options_values_id, options_values_price, price_prefix, pr
+oducts_options_sort_order)
                        VALUES (?, ?, ?, ?, ?, ?)');

foreach $line (@nametape) {
....
    $query->execute($products_id, $options_id, $options_values_id, $op
+tions_values_price, $price_prefix, $products_options_sort_order) or e
+xit 1;   
}

[download]

Think about other things such as the assignment of $options_id which could be moved outside the loop as well.

In reply to Re^2: foreach and lists by hippo
in thread foreach and lists by almoodie

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.