More than looking inefficient, it looks unnecessarily cluttered, which can contribute to bugs:
- [\D]? is the same as \D?. This is repeated four times.
- [0|1] is probably a mistake; character classes don't use alternation, and I don't see any | characters in your sample input. You probably mean [01]
- \D?\d{4} is repeated twice in a row. How about (?:\D?\d{4}){2} ?
Making those changes would yield:
9818\D?9[01]\D?\d{2}(?:\D?\d{4}){2}
Now with the /x modifier, you can further clarify things like this:
m/
9818 # A literal.
\D? # Optional non-digit.
[01] # Require a zero or a one.
\D? # Another optional non-digit.
\d{2} # Require two digits.
(?: # Group but don't capture.
\D? # Another optional non-digit.
\d{4} # Followed by four digits.
){2} # Repeated twice.
/x
As for efficiency, what problems are you encountering? If you're dealing with huge input you're probably IO bound anyway.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.