Finally, from a stylistic point of view, you're calling main and then declaring it a line later .. you can just skip both of those steps. Here's how I would re-format your code..
use strict;
use warnings;
use Text::CSV_XS;
{
my @row1 = ("aaa","fff","sss" );
my @row2 = ("bbb","fff","sss");
# should set binary att
my $csv = Text::CSV_XS->new ( { binary => 1 } )
or die "Cannot use CSV: ".Text::CSV->error_diag ();
open my $fh, ">:encoding(utf8)", "new.csv"
or die "Failed to open new.csv for writing: $!";
$csv->print ($fh, \@row1);
$csv->print ($fh, \@row2);
close $fh or die "Failed to close new.csv: $!";
print " finished \n";
}
- I've added the use of strict and warnings -- the Perl compiler should be happy with your code;
- I'm declaring the variables at the point at which they're used, rather than at the top of the program;
- I've expanded the error messages to be more informative; your version would show the same error for both open and close errors;
- I've spaced things out to make the code more readable -- I'm a fan of blank lines to separate chunks of code;
You could get more cleanup by using perltidy -- I'm a fan of this utility.
Alex / talexb / Toronto
"Groklaw is the open-source mentality applied to legal research" ~ Linus Torvalds
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.