This will get rid of the terminal $ for you. It is also a good idea to specify a path when opening files. 

use Win32::NetAdmin;

my $path = 'c:';
my $file = 'list.txt';

open ( OUT, ">$path/$file" ) ||
    die "Cannot create machine list. :$!";

my @users;
Win32::NetAdmin::GetUsers("\\\\PDC",'',\@users);
my @computers = grep { /\$$/ } @users;
for my $box (@computers) {
   chop $box;          # removes terminal char, must be $ from grep
   print OUT "$box\n"; # print each $box on a newline
}
close OUT;

[download]

In the second script you read from a file using a while loop but never look at the contents of that file! Each line will be assigned to $_ in turn. You need to chomp off the newline as well. 

while (<IN>) {
    my $line = $_;
    chomp $line;
    # now do something with $line which we got from the file
}

[download]

As a final note the join is not doing what I think you think it is doing :-) Join returns a scalar not a list thus assigning it to an array does not make. You will note that after the join the whole array is in element 0. 

@ary = qw(1 2 3 4 5);
print "first ", $ary[0], "\n";
@ary = join("\n",@ary);
print "second", $ary[0], "\n";

[download]

Hope this helps

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

In reply to Re: getting server names in the domain and looking up ips by tachyon
in thread getting server names in the domain and looking up ips by RayRay459

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.