Two small things:

# Check if a destination is defined unless (defined $destination) { showUsage (); }

I would like an improved error message here, like

# Check if a destination is defined unless (defined $destination) { print "No destination given.\n"; showUsage (); }

And at the place where you run rsync, you capture all of its (voluminous) output just to print it out right afterwards:

# Run the program and show the output my @result; @result = `$cmd 2>&1`; foreach my $result (@result) { print $result; chomp $result; }

I would change that to simply use system instead, which will do the printing directly. This would also add error checking so your script signals if the underlying rsync failed:

# Run the program and show the output system( "$cmd 2>&1") == 0 or die "rsync failed: $! / $?";

Of course, if you really want/need to do post-processing of the rsync output, as your chomp indicates, you will need to capture the output as you did.


In reply to Re: Feedback on my second script by Corion
in thread Feedback on my second script by Jackiejarvis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.