If you are returning large amounts of text/html, consider using "heredocs". It means you don't need to escape quotes and the HTML you output can be read easily. The code is at the bottom of this comment.
Doing it this way shows several things more clearly:
- Why use "local our" instead of "my" to declare your subroutine variables? If you read the Perl documentation it says in the first para you probably should not be using it
- $enchereurer may be undefined if $enchere is empty or undefined. You had also best check that $articleClass->getLastEnchereurDetail() is guaranteed to return a string of some sort
- Where is the %ARTICLE hash and the $articleClass object declared? Using global data inside routines is (normally, but not always) bad practice.
- You are concatenating on to the end of $string even though you have not defined it. Perl may or may not accept this, but it's poor coding.
sub loadFabricantProperties {
my $fabricant = shift || '';
my $libelle = shift || $SERVER{'fabricant'};
my $enchere = shift || '';
# just because the bidder loves ternary operators....
my $encherereur = $enchere ?
$articleClass->getLastEnchereurDetail() :
'';
my $string = <<EOF;
<tr>
<td align="left">$libelle</td>
<td align="left">
<input type="text" name="fabricant"
value="$ARTICLE{'author'}"
onchange="validateInput();">
</td>
$encherereur
</tr>
EOF
return $string;
}
If you spot any bugs in my solutions, it's because I've deliberately left them in as an exercise for the reader! :-)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.